-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.9.255.9 #45
8.9.255.9 #45
Conversation
Original commit message: Fixes compilation with msvc 2019 toolchain.
@gengjiawen I don't really have time at the moment to investigate and push this through but if you want to pick up where I left off, I'm happy to make you co-maintainer. |
Sure :) |
@gengjiawen No pressure at all but I was wondering if you managed to make any progress on this? You received (and accepted) the invitation, right? |
Not fully into it. Looks like this part not working if(WIN32)
list(APPEND heap-sources
$<${is-arm64}:v8/src/heap/base/asm/arm64/push_registers_masm.S>
$<${is-ia32}:v8/src/heap/base/asm/ia32/push_registers_masm.S>
$<${is-x64}:v8/src/heap/base/asm/x64/push_registers_masm.S>
)
Yeap. |
@bnoordhuis looks build passed. |
Sweet, merged. You want to try to do the next upgrade? |
8.9.255.9 (bnoordhuis#45)
No description provided.