Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.9.255.9 #45

Merged
merged 3 commits into from
Mar 24, 2021
Merged

8.9.255.9 #45

merged 3 commits into from
Mar 24, 2021

Conversation

bnoordhuis
Copy link
Owner

No description provided.

@gengjiawen
Copy link
Collaborator

Upstream: https://chromium-review.googlesource.com/c/v8/v8/+/2711152

Original commit message:

    Fixes compilation with msvc 2019 toolchain.
@bnoordhuis
Copy link
Owner Author

@gengjiawen I don't really have time at the moment to investigate and push this through but if you want to pick up where I left off, I'm happy to make you co-maintainer.

@gengjiawen
Copy link
Collaborator

gengjiawen commented Mar 15, 2021

@gengjiawen I don't really have time at the moment to investigate and push this through but if you want to pick up where I left off, I'm happy to make you co-maintainer.

Sure :)

@bnoordhuis
Copy link
Owner Author

@gengjiawen No pressure at all but I was wondering if you managed to make any progress on this? You received (and accepted) the invitation, right?

@gengjiawen
Copy link
Collaborator

@gengjiawen No pressure at all but I was wondering if you managed to make any progress on this?

Not fully into it. Looks like this part not working

if(WIN32)
  list(APPEND heap-sources
    $<${is-arm64}:v8/src/heap/base/asm/arm64/push_registers_masm.S>
    $<${is-ia32}:v8/src/heap/base/asm/ia32/push_registers_masm.S>
    $<${is-x64}:v8/src/heap/base/asm/x64/push_registers_masm.S>
  )

You received (and accepted) the invitation, right?

Yeap.

@gengjiawen
Copy link
Collaborator

@bnoordhuis looks build passed.

@bnoordhuis bnoordhuis merged commit 9075563 into master Mar 24, 2021
@bnoordhuis
Copy link
Owner Author

Sweet, merged. You want to try to do the next upgrade?

MBeijer added a commit to MBeijer/v8-mingw64 that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants