Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]return error when executing mirror or mirror sync request failed #823

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

yutianwu
Copy link
Contributor

Description

For now, we did not return error when executing mirror or mirror sync request failed, so recon service can not get the relay fee. So we add the related error for these cross chain apps.

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • integration tests passed (make integration_test)
  • manual transaction test passed (cli invoke)

Already reviewed by

...

Related issues

... reference related issue #'s here ...

@yutianwu yutianwu changed the title return error when execute mirror or mirror sync request failed return error when executing mirror or mirror sync request failed Jan 22, 2021
@yutianwu yutianwu changed the base branch from master to develop January 22, 2021 09:00
@yutianwu yutianwu changed the title return error when executing mirror or mirror sync request failed [R4R]return error when executing mirror or mirror sync request failed Jan 26, 2021
@yutianwu yutianwu merged commit 8cb1f19 into develop Jan 26, 2021
@unclezoro unclezoro mentioned this pull request Jan 26, 2021
4 tasks
This was referenced Jan 26, 2021
@unclezoro unclezoro deleted the fix_event branch May 10, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants