Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marshal time error for amino require time in seconds should be less than 253402300800 #640

Closed
yutianwu opened this issue Aug 5, 2019 · 0 comments

Comments

@yutianwu
Copy link
Contributor

yutianwu commented Aug 5, 2019

When we pass a time larger than 253402300800 in time lock request, it will panic:

image

the root cause is amino require time in seconds less than 253402300800, and a unix timestamp is int64.

const (
	// seconds of 01-01-0001
	minSeconds int64 = -62135596800
	// seconds of 10000-01-01
	maxSeconds int64 = 253402300800

	// nanos have to be in interval: [0, 999999999]
	maxNanos = 999999999
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant