Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up all the ABCI error messges #480

Closed
darren-liu opened this issue Mar 6, 2019 · 0 comments
Closed

clean up all the ABCI error messges #480

darren-liu opened this issue Mar 6, 2019 · 0 comments
Assignees
@rickyyangz
Labels
enhancement New feature or request

Comments

@darren-liu
Copy link
Contributor

The error message should be meaningful to users and not expose too much internal logic.

bad example:

		return sdk.NewError(
				types.DefaultCodespace,
				types.CodeFailInsertOrder,
				"cannot get txHash from ctx").Result()
@darren-liu darren-liu added the enhancement New feature or request label Mar 6, 2019
@rickyyangz rickyyangz mentioned this issue Mar 8, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickyyangz rickyyangz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darren-liu @rickyyangz