feat: add support for eth address standard #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Nov 9, 2022
unclezoro
reviewed
Nov 9, 2022
unclezoro
reviewed
Nov 9, 2022
unclezoro
reviewed
Nov 9, 2022
unclezoro
reviewed
Nov 9, 2022
unclezoro
reviewed
Nov 11, 2022
unclezoro
reviewed
Nov 11, 2022
unclezoro
reviewed
Nov 11, 2022
unclezoro
reviewed
Nov 11, 2022
github-actions
bot
added
C:x/crisis
C:x/evidence
C:x/gov
C:x/mint
C:x/nft
C:x/params
C:x/upgrade
and removed
C:Keys
labels
unclezoro
force-pushed
the
wallet_support
branch
from
588ee66
to
0846a58
Compare
unclezoro
reviewed
Dec 7, 2022
unclezoro
reviewed
Dec 7, 2022
unclezoro
reviewed
Dec 8, 2022
unclezoro
reviewed
Dec 8, 2022
unclezoro
reviewed
Dec 8, 2022
unclezoro
reviewed
Dec 8, 2022
| @@ -4,6 +4,11 @@ import ( | |||
| "crypto/sha256" | |||
| ) | |||
|
|
|||
| // CurveType | |||
| const ( | |||
| EthSecp256k1 = "Eth_secp256k1" | |||
There was a problem hiding this comment.
A useless definition here.
There was a problem hiding this comment.
Will we use rosetta service?
unclezoro
reviewed
Dec 8, 2022
unclezoro
reviewed
Dec 8, 2022
pythonberg1997
force-pushed
the
wallet_support
branch
from
369040f
to
ee1ee03
Compare
unclezoro
approved these changes
Dec 13, 2022
unclezoro
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for eth address standard
Rationale
In order that users could sign BFS transactions by a ethereum wallet like MetaMask directly, we adopt eth's secp256k1 and address rules as our keys algorithm.
Example
N/A
Changes
Notable changes:
Addressimplement,ETHAddress, which is compatible of BSC address