Skip to content

upstream: Prague code merge [v1.13.15, v1.14.11] #3712

upstream: Prague code merge [v1.13.15, v1.14.11]

upstream: Prague code merge [v1.13.15, v1.14.11] #3712

Triggered via pull request November 22, 2024 07:22
Status Failure
Total duration 45s
Artifacts

commit-lint.yml

on: pull_request
Matrix: commitlint
Fit to window
Zoom out
Zoom in

Annotations

1 error and 1 warning
commitlint (14.x, ubuntu-latest)
You have commit messages with errors ⧗ input: cmd, core: prefetch reads too from tries if requested (#29807) * cmd/utils, consensus/beacon, core/state: when configured via stub flag: prefetch all reads from account/storage tries, terminate prefetcher synchronously. * cmd, core/state: fix nil panic, fix error handling, prefetch nosnap too * core/state: expand prefetcher metrics for reads and writes separately * cmd/utils, eth: fix noop collect witness flag --------- Co-authored-by: Péter Szilágyi <[email protected]> ✖ body's lines must not be longer than 100 characters [body-max-line-length] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md ⧗ input: core/state, eth/protocols, trie, triedb/pathdb: remove unused error from trie Commit (#29869) * core/state, eth/protocols, trie, triedb/pathdb: remove unused error return from trie Commit * move set back to account-trie-update block scoping for easier readability * address review * undo tests submodule change * trie: panic if BatchSerialize returns an error in Verkle trie Commit * trie: verkle comment nitpicks --------- Co-authored-by: Péter Szilágyi <[email protected]> ✖ header must not be longer than 80 characters, current length is 94 [header-max-length] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md ⧗ input: common: using `ParseUint` instead of `ParseInt` (#30020) Since Decimal is defined as unsiged `uint64`, we should use `strconv.ParseUint` instead of `strconv.ParseInt` during unmarshalling. --------- Co-authored-by: Martin Holst Swende <[email protected]> ✖ body's lines must not be longer than 100 characters [body-max-line-length] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md ⧗ input: core/state: fix SetStorage override behavior (#30185) ⚠ footer must have leading blank line [footer-leading-blank] ⚠ found 0 problems, 1 warnings ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md ⧗ input: eth/tracers, internal/ethapi: remove unnecessary map pointer in state override (#30094) ✖ header must not be longer than 80 characters, current length is 87 [header-max-length] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md ⧗ input: eth/catalyst: get params.ExcessBlobGas but check with params.BlobGasUsed (#30267) Seems it is checked with the wrong argument Signed-off-by: jsvisa <[email protected]> ✖ header must not be longer than 80 characters, current length is 81 [header-max-length] ✖ found 1 problems, 0 warnings ⓘ Get help: https://github.com/bnb-chain/bsc/tree/develop/docs/lint/commit.md
commitlint (14.x, ubuntu-latest)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/