From 47b9f25d08f1520834315e4870711e826e4a6284 Mon Sep 17 00:00:00 2001 From: forcodedancing Date: Thu, 14 Apr 2022 21:10:46 +0800 Subject: [PATCH] static analysis changes --- baseapp/baseapp.go | 2 -- server/constructors.go | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/baseapp/baseapp.go b/baseapp/baseapp.go index 9503c0ea7..4c55b846d 100644 --- a/baseapp/baseapp.go +++ b/baseapp/baseapp.go @@ -257,8 +257,6 @@ func (app *BaseApp) initFromStore(mainKey sdk.StoreKey) error { blockDB.Close() } - //TODO(#118): figure out what does this mean! If we keep this, we will get panic: Router() on sealed BaseApp at github.com/BiJie/BinanceChain/app.(*BinanceChain).GetRouter(0xc0004bc080, 0xc000c14000, 0xc0007b9808) - // /Users/zhaocong/go/src/github.com/BiJie/BinanceChain/app/app.go:297 +0x6b //app.Seal() return nil diff --git a/server/constructors.go b/server/constructors.go index 57282e43b..573644b7b 100644 --- a/server/constructors.go +++ b/server/constructors.go @@ -33,7 +33,7 @@ func openTraceWriter(traceWriterFile string) (w io.Writer, err error) { w, err = os.OpenFile( traceWriterFile, os.O_WRONLY|os.O_APPEND|os.O_CREATE, - 0666, + 0600, ) return }