Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When validating an entry, ensure that saveframe pointers point to saveframes of the correct category #90

Open
jonwedell opened this issue Jan 29, 2021 · 2 comments
Assignees

Comments

@jonwedell
Copy link
Member

An NMR-STAR file with invalid pointers caused the deposition system to not function properly. Therefore it is a class of issue that should be checked for here as well.

@jonwedell jonwedell self-assigned this Jan 29, 2021
@dmaziuk
Copy link

dmaziuk commented Jan 29, 2021

what are the "saveframe pointers"? -- if you mean the $foo labels, at the STAR level they just need to point to "a saveframe". You have to look at parent-child relationships in the dictionary to figure 'em out, and they are not on the saveframe label tags IIRC, they were set on ID tags last I looked. There was a flag somewhere matching the _ID to its corresp. _label tag.

@jonwedell
Copy link
Member Author

Indeed, it will take one or more dictionary lookups to check this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants