From 12994cf7606150554f12e16105a05570c4990c3a Mon Sep 17 00:00:00 2001 From: Thomas Bouamoud Date: Wed, 24 Jan 2024 18:42:34 +0000 Subject: [PATCH] updates based on PR comments --- CHANGES.md | 2 +- cryptofeed/exchanges/coinbase.py | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index ca6208365..f23c7c7ba 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,6 +1,6 @@ ## Changelog -### 2.5.0 +### 2.4.2 * Update: transitioned from Coinbase Pro (retired) to Coinbase Advanced Trade ### 2.4.1 diff --git a/cryptofeed/exchanges/coinbase.py b/cryptofeed/exchanges/coinbase.py index bf2f41b0e..3cf63882a 100644 --- a/cryptofeed/exchanges/coinbase.py +++ b/cryptofeed/exchanges/coinbase.py @@ -88,14 +88,6 @@ def __init__(self, callbacks=None, **kwargs): def __reset(self): self._l2_book = {} - async def _ticker(self, msg: dict, timestamp: float): - # TODO: The ticker endpoint payload has been updated and no longer includes best ask and bid. - # Do we want to: - # 1. get rid of that callback - # 2. implement ticker based on l2 book sub - # 3. implement a new ticker callback (will be different from other exchanges) - raise NotImplementedError - async def _trade_update(self, msg: dict, timestamp: float): ''' {