From e03022efdb3d3d87933bc119d98185ae3fcdeb8d Mon Sep 17 00:00:00 2001 From: Chengzhong Wu Date: Thu, 6 Jun 2024 11:13:17 +0100 Subject: [PATCH] build: generate binlog in out directories Directories link `Release\` will be created as a junction to `out\Release` when build completes. When binlog was written to `Release\` before the junction is created, the build will fail for unable to create junction when directory `Release\` already exists. PR-URL: https://github.com/nodejs/node/pull/53325 Reviewed-By: Stefan Stojanovic Reviewed-By: Luigi Pinca --- vcbuild.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vcbuild.bat b/vcbuild.bat index a3c9c0484eccc5..ece0afa649e78c 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -142,7 +142,7 @@ if /i "%1"=="cctest" set cctest=1&goto arg-ok if /i "%1"=="openssl-no-asm" set openssl_no_asm=1&goto arg-ok if /i "%1"=="no-shared-roheap" set no_shared_roheap=1&goto arg-ok if /i "%1"=="doc" set doc=1&goto arg-ok -if /i "%1"=="binlog" set extra_msbuild_args=/binaryLogger:%config%\node.binlog&goto arg-ok +if /i "%1"=="binlog" set extra_msbuild_args=/binaryLogger:out\%config%\node.binlog&goto arg-ok echo Error: invalid command line option `%1`. exit /b 1