New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColoredNoise deformer bug #84

Open

lylyhan opened this issue Aug 24, 2020 · 1 comment

Labels

bug

lylyhan commented Aug 24, 2020

error (dimension mismatch) occurs when applying a pipeline that includes coloredNoise deformer and IRConvolution deformer.

where the original audio length is 118882 samples, impulse response length is 192000 samples.

bmcfee added the bug label

Owner

bmcfee commented Aug 25, 2020

The problem comes from this chunk: https://github.com/bmcfee/muda/blob/master/muda/deformers/colorednoise.py#L43-L59

The issue is that we're using rfft, but not explicitly setting the signal length when calling irfft, so odd-length signals get corrupted.

I'll rewrite this module some time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment