Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapping CREMA models as PUMPP feature extractors #25

Closed
tomxi opened this issue Aug 16, 2019 · 1 comment
Closed

wrapping CREMA models as PUMPP feature extractors #25

tomxi opened this issue Aug 16, 2019 · 1 comment

Comments

@tomxi
Copy link

tomxi commented Aug 16, 2019

This is to facilitate #24, as it uses the CREMA/chord model as a feature extractor.

Suggesting there should be a new module pumpp.py which access the chord model from analyze, and wraps the model in as a pumpp feature extractor. (related: bmcfee/pumpp#110)

There should also be a model getter function to interface with __MODEL__ in analyze, so the feature extractor can have access to the model.

@tomxi
Copy link
Author

tomxi commented Feb 17, 2021

no need after #24 is closed.

@tomxi tomxi closed this as completed Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant