Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review SubstanceType and CAS numbers #50

Open
montanajava opened this issue Apr 11, 2024 · 2 comments
Open

Review SubstanceType and CAS numbers #50

montanajava opened this issue Apr 11, 2024 · 2 comments
Labels
enhancement New feature or request jira Tag to activate JIRA integration v2 A major release Vs. 2

Comments

@montanajava
Copy link
Collaborator

A specific substance can have multiple CAS numbers. We are currently putting these under alternateId. This results in multiple alternateIds (which is allowed by the XSD), with the same sourceSystemId (which is also allowed by the XSD).

Is this what we want? Do we want a special PSM substanceType which explicitly denotes CAS numbers. They main reason for asking is because if we have duplicate sourceSystemIds in an Identifier, then it really cannot be an Identifier at all. This may be okay, and may be just a philosophical instance of something not being entirely clean.

@montanajava montanajava added the v2 A major release Vs. 2 label Apr 11, 2024
@montanajava montanajava added the enhancement New feature or request label May 13, 2024
@montanajava
Copy link
Collaborator Author

ProductCatalog is already using this. We can regard that as a strong statement that this is a solid requirement and verified at least in that context.

@AFoletti AFoletti added the jira Tag to activate JIRA integration label Aug 14, 2024
@AFoletti
Copy link
Member

AFoletti commented Dec 4, 2024

I have the feeling that this should be solved elsewhere (PSM). Still keeping it open for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jira Tag to activate JIRA integration v2 A major release Vs. 2
Projects
None yet
Development

No branches or pull requests

2 participants