Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#305 - 404 page + design updates #329

Merged
merged 4 commits into from
Aug 28, 2024
Merged

#305 - 404 page + design updates #329

merged 4 commits into from
Aug 28, 2024

Conversation

AleksandraKozubal
Copy link
Member

@AleksandraKozubal AleksandraKozubal commented Aug 26, 2024

I did 404 page along with updates and fixes in other pages. Removed some unnecessary files, added :fresh to environment/dev/scripts/init.sh, added shadows, removed big bubbles (from contact and company data page) and sections placement, color and size changes.

Desktop design
Mobile design

image
image

It should close #305.

@AleksandraKozubal AleksandraKozubal marked this pull request as ready for review August 26, 2024 12:34
@AleksandraKozubal AleksandraKozubal requested a review from a team as a code owner August 26, 2024 12:34
@AleksandraKozubal AleksandraKozubal changed the title #305 - 404 page #305 - 404 page + design updates Aug 26, 2024
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page title is not translated

image

@@ -25,29 +25,36 @@
</head>

<body class="font-sora flex flex-col h-screen justify-between">
@php $excludeBigBubbles = false; @endphp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@php $excludeBigBubbles = false; @endphp
@php $excludeBigBubbles = false; @endphp

👀

@AleksandraKozubal AleksandraKozubal merged commit d754911 into main Aug 28, 2024
3 checks passed
@AleksandraKozubal AleksandraKozubal deleted the #305-404-page branch August 28, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 page
3 participants