Convert Service to REST using FastAPI and Make ScanSpecs Pydantic Models #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2022
Closed
callumforrester
force-pushed
the
fastapi-and-pydantic
branch
from
787423e to
f5dd916
Compare
WIP WIP2 Working union
callumforrester
force-pushed
the
fastapi-and-pydantic
branch
from
867a181 to
888d6f2
Compare
callumforrester
commented
Jan 4, 2023
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 95.56% 96.04% +0.48%
==========================================
Files 9 9
Lines 902 886 -16
==========================================
- Hits 862 851 -11
+ Misses 40 35 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
callumforrester
changed the title
coretl
reviewed
Jan 23, 2023
DiamondJoseph
added a commit
to DiamondLightSource/tickit
that referenced
this pull request
Jul 10, 2023
- Replace as_tagged_union with equivalent discriminated_union_of_subclasses from bluesky/scanspec#56 - Replace dataclass usage with Pydantic dataclass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline, merging #52 and #53 into one big PR.
@discriminated_union_of_subclassesto enable similar tagged union behaviour to the GraphQL service