Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panda should have "name" kwarg in constructor #98

Closed
rosesyrett opened this issue Jan 4, 2024 · 1 comment · Fixed by #101
Closed

Panda should have "name" kwarg in constructor #98

rosesyrett opened this issue Jan 4, 2024 · 1 comment · Fixed by #101
Assignees

Comments

@rosesyrett
Copy link
Collaborator

In a recent change I did this:

3aaedaf

I'm no longer sure I should have done that; MX are using pandas and connecting them/ creating them with names.

The rationale behind the original idea, was to decouple Device hierarchy from naming. I think I originally thought about this in terms of the DeviceCollector. So this is an issue to:

  1. Discuss if we should have hierarchies just for naming things (i.e. calls to super().__init__(name=name) for the sole purpose of setting a name)
  2. Revert the above change.
@rosesyrett rosesyrett self-assigned this Jan 4, 2024
@rosesyrett
Copy link
Collaborator Author

Decided to just reinstate name. I'll go ahead and do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants