Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pattern Generator dataset creation is not correct, and has no tests to catch it. #432

Closed
abbiemery opened this issue Jul 4, 2024 · 0 comments · Fixed by #436
Closed

Pattern Generator dataset creation is not correct, and has no tests to catch it. #432

abbiemery opened this issue Jul 4, 2024 · 0 comments · Fixed by #436
Assignees
@subinsaji

Comments

@abbiemery
Copy link
Collaborator

abbiemery commented Jul 4, 2024 •
edited
Loading

The changes in #429 broke the pattern generator, and this issue is to get it working again with appropriate system test coverage.

The tests need to cover its use as it would be run using the demo.

Changes required for the init of PatternGenerator:

  • shape of a frame is [detector_height, detector_width]
  • shape of the DATA HDF dataset is [1, detector_height, detector_width]
  • fill value for SUM dataset is -1, not required for the dataset
  • maxshape for the DATA HDF dataset = [None, detector_height, detector_width]

As in the original code in bluefly https://github.com/dls-controls/bluefly/blob/0ee7ea837d5f74e3cdc69e2315e9beed28dd7766/bluefly/areadetector_sim.py#L55-L68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@subinsaji subinsaji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pattern generator tests bluesky/ophyd-async
2 participants
@abbiemery @subinsaji