Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SLF001 ruff check #299

Closed
coretl opened this issue May 10, 2024 · 4 comments · Fixed by #483
Closed

Enable SLF001 ruff check #299

coretl opened this issue May 10, 2024 · 4 comments · Fixed by #483
Assignees

Comments

@coretl
Copy link
Collaborator

coretl commented May 10, 2024

As per DiamondLightSource/python-copier-template#154

@stan-dot
Copy link
Contributor

stan-dot commented Jun 5, 2024

SLF001 is about private class method/property access

@abbiemery abbiemery added this to the 0.6 milestone Jun 11, 2024
@evalott100 evalott100 self-assigned this Jul 2, 2024
@coretl
Copy link
Collaborator Author

coretl commented Jul 3, 2024

Waiting for #383

@coretl coretl removed this from the 0.6 milestone Jul 3, 2024
@coretl
Copy link
Collaborator Author

coretl commented Jul 23, 2024

@abbiemery I merged this into the copier template main, please could you try doing a copier update --vcs-ref=main and check this works?

@abbiemery
Copy link
Collaborator

I did the changes to ophyd-async that are JUST the SLF ones, as the other ones on the copier template bring in a lot of errors to fix. I suggest we merge the SLF changes now, and make issues to adopt the other ones.

#483

@abbiemery abbiemery linked a pull request Jul 24, 2024 that will close this issue
@abbiemery abbiemery assigned abbiemery and unassigned evalott100 Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants