-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding a layer to remove coupling with views and BlueskyRun API #65
Comments
Another important consequence of this is that the bottom layer |
Also, if h/t @tacaswell |
#97 does this almost entirely. It moves the 1:1 correspondence to |
@tacaswell shared this snippet of work related to matplotlib 4.0 https://gist.github.com/tacaswell/95177903175dbc28be5353b4a0e5118f. Keeping this here so I don't lose it. |
The view code knows about of the concept of a
BlueskyRun
and its particular interface and signals:bluesky-widgets/bluesky_widgets/_matplotlib_axes.py
Lines 104 to 105 in 434046b
bluesky-widgets/bluesky_widgets/_matplotlib_axes.py
Lines 121 to 125 in 434046b
What if, instead, we separate the bluesky-aware aspect into a separate components, perhaps by subclassing like so:
then
LineSpec
and the views become generic. That would extend the utility of these components at the cost of an additional layer of signaling.The text was updated successfully, but these errors were encountered: