From 8deb66ffed818e8d017c8f15dba09de54ef64a18 Mon Sep 17 00:00:00 2001 From: Hailey Date: Tue, 30 Apr 2024 10:54:22 -0700 Subject: [PATCH 1/2] use the correct keyboard appearance based on theme --- src/screens/Messages/Conversation/MessageInput.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/screens/Messages/Conversation/MessageInput.tsx b/src/screens/Messages/Conversation/MessageInput.tsx index 3a3ce38f66..1a63b1b5b2 100644 --- a/src/screens/Messages/Conversation/MessageInput.tsx +++ b/src/screens/Messages/Conversation/MessageInput.tsx @@ -47,6 +47,7 @@ export function MessageInput({ onFocus={onFocus} onBlur={onBlur} placeholderTextColor={t.palette.contrast_500} + keyboardAppearance={t.name === 'light' ? 'light' : 'dark'} ref={inputRef} /> Date: Tue, 30 Apr 2024 11:15:07 -0700 Subject: [PATCH 2/2] i guess the min index should be 1 --- src/screens/Messages/Conversation/MessagesList.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/screens/Messages/Conversation/MessagesList.tsx b/src/screens/Messages/Conversation/MessagesList.tsx index e3b518f65b..844139f6ae 100644 --- a/src/screens/Messages/Conversation/MessagesList.tsx +++ b/src/screens/Messages/Conversation/MessagesList.tsx @@ -164,23 +164,23 @@ export function MessagesList({chatId}: {chatId: string}) { keyExtractor={item => item.id} renderItem={renderItem} contentContainerStyle={{paddingHorizontal: 10}} + inverted={true} // In the future, we might want to adjust this value. Not very concerning right now as long as we are only // dealing with text. But whenever we have images or other media and things are taller, we will want to lower // this...probably. initialNumToRender={20} // Same with the max to render per batch. Let's be safe for now though. maxToRenderPerBatch={25} - inverted={true} + removeClippedSubviews={true} onEndReached={onEndReached} onScrollToIndexFailed={onScrollToEndFailed} onContentSizeChange={onContentSizeChange} onViewableItemsChanged={onViewableItemsChanged} viewabilityConfig={viewabilityConfig} maintainVisibleContentPosition={{ - minIndexForVisible: 0, + minIndexForVisible: 1, }} ListFooterComponent={} - removeClippedSubviews={true} ref={flatListRef} keyboardDismissMode="none" />