Does the AppView not currently enforce image blob size limits or accept types? #2845
snarfed
started this conversation in
Protocol (atproto)
Replies: 2 comments
-
We're currently adding image processing in snarfed/granary#844 to get aspect ratios, and we'll probably use our own higher limit for images, maybe 5MB, since the appview still doesn't seem to enforce the lexicon's 1M limit. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Catching up on some old reports! This one is quite interesting. I think the short answer is that the bsky appview implementation is not being strict enough here; these posts should be rejected. cc: @devinivy @ericvolp12 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi all! I recently implemented (well, finished) lexicon schema validation for stored/emitted records and XRPC method input, output, and params, and I've been seeing a trickle of surprising failures on data that the AppView is evidently ok with. One big one: it seems like image blobs are often allowed with types and sizes that don't satisfy
maxSize
oraccept
. Is this known?A couple specific examples:
size
1858016, which is larger thanmaxSize: 1000000
onapp.bsky.embed.images#image
, but the AppView allowed it and it's visible on the post.avatar
(getBlob call) withmime_type: image/webp
, which doesn't satisfyaccept: [image/png, image/jpeg]
onapp.bsky.actor.profile
, but the AppView allowed it and it's visible on the profile.Totally ok if this is expected! I'm just trying to understand how to reconcile it with any lexicon schema validation I do on my end.
Thanks in advance!
(re: snarfed/bridgy-fed#1348, snarfed/bridgy-fed#1349 (comment))
Beta Was this translation helpful? Give feedback.
All reactions