Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs: allow digits in DID method #292

Open
5 tasks
bnewbold opened this issue Feb 13, 2024 · 2 comments
Open
5 tasks

specs: allow digits in DID method #292

bnewbold opened this issue Feb 13, 2024 · 2 comments
Labels
bug Something isn't working specs

Comments

@bnewbold
Copy link
Contributor

Allowing digits does seem to be correct upstream:
https://www.w3.org/TR/did-core/#did-syntax

and there are methods like did:3 and did:web7 which use them:
https://w3c.github.io/did-spec-registries/#did-methods

As part of this change we should:

  • update the specs and examples
  • update the shared interop test vectors
  • update golang SDK (indigo)
  • update typescript SDK (atproto)
  • dev comms to other promoted SDK maintainers

Feels like a bit of a bummer that they allow this as it visually blurs with host:port style syntax, but I guess the required second colon disambiguates.

cc: @matthieusieben

@matthieusieben
Copy link
Contributor

Note that the host:port must be url encoded in did:web, which means that the colon : as port separator is never really visible anyway..

@bnewbold
Copy link
Contributor Author

what I meant was the kind of visual/superficial confusion between:

https://did:8080/app.bsky.feed.post/abc123
at://did:80:80/app.bsky.feed.post/abc123

I think it is a tiny bit less confusing if it had to be:

at://did:eighty:80/app.bsky.feed.post/abc123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working specs
Projects
None yet
Development

No branches or pull requests

2 participants