Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plotter widget #1478

Merged

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Nov 29, 2024

Allows the user to plot any data-lake variable.

Kapture.2024-11-30.at.06.42.16.mp4

⚠️ To be merged after #1477.

Relevant to #85.

@ES-Alexander
Copy link
Contributor

Hooray! 😃

Looking great so far!


I do think the appearance stuff would make more sense as immediately exposed (with pop-ups when clicking on a specific colour), and with line width controllable as well, e.g.

Background Color | Line Color | Line Width
 BG #335544BB | FG #FF1778FF | [1px ] -ⓞ---------


I also think the Data Points section could be compressed into a single line - the "Maximum samples" box could easily be half width instead:

   Maximum samples
[ 1000 ] ⊂ⓞ Limit samples?
   Higher values show more history,
   but may affect performance


There are a bunch more ideas in #85, but fair enough to keep it simple to start with :-)

Copy link
Contributor

@ArturoManzoli ArturoManzoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome widget!

One suggestion: Add a line thickness option

There are some changes needed:
1- The color selector popover is closing every time the user select a color. On the V-Color-Picker there is a prop (I think its: close-on-content-click="false") that could control this.
2- (1): center the title;
(2): You can group those two other props horizontally on a row, saving vertical space;
(3): Add a standard footer with the separator line and a close text button.

image

@rafaellehmkuhl rafaellehmkuhl force-pushed the add-plotter-widget branch 2 times, most recently from 0cf3618 to d4cab1c Compare December 9, 2024 13:25
@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Dec 9, 2024

Awesome widget!

One suggestion: Add a line thickness option

There are some changes needed: 1- The color selector popover is closing every time the user select a color. On the V-Color-Picker there is a prop (I think its: close-on-content-click="false") that could control this. 2- (1): center the title; (2): You can group those two other props horizontally on a row, saving vertical space; (3): Add a standard footer with the separator line and a close text button.

Everything addressed!

image

Comment on lines 90 to 91
<v-checkbox v-model="widget.options.limitSamples" label="Limit number of samples" color="primary" />
<v-text-field
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this checkbox white instead of primary? It will be way more visible
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

This is a plot widget that can be configured to consume from any data-lake variable of type `number`.
@joaoantoniocardoso
Copy link
Member

image
These numbers will be hard to read when over the data points. Could we have a background for those texts?

@joaoantoniocardoso
Copy link
Member

image These numbers will be hard to read when over the data points. Could we have a background for those texts?

Nevermind, you already did that hahaha

@rafaellehmkuhl
Copy link
Member Author

These numbers will be hard to read when over the data points. Could we have a background for those texts?

Nevermind, you already did that hahaha

Was coming here to say that 😆

@ArturoManzoli ArturoManzoli merged commit a982448 into bluerobotics:master Dec 9, 2024
10 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the add-plotter-widget branch December 9, 2024 15:09
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-needed Change needs to be documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants