-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Plotter widget #1478
Add Plotter widget #1478
Conversation
Hooray! 😃 Looking great so far! I do think the appearance stuff would make more sense as immediately exposed (with pop-ups when clicking on a specific colour), and with line width controllable as well, e.g.
I also think the Data Points section could be compressed into a single line - the "Maximum samples" box could easily be half width instead: Maximum samples There are a bunch more ideas in #85, but fair enough to keep it simple to start with :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome widget!
One suggestion: Add a line thickness option
There are some changes needed:
1- The color selector popover is closing every time the user select a color. On the V-Color-Picker there is a prop (I think its: close-on-content-click="false") that could control this.
2- (1): center the title;
(2): You can group those two other props horizontally on a row, saving vertical space;
(3): Add a standard footer with the separator line and a close text button.
0cf3618
to
d4cab1c
Compare
src/components/widgets/Plotter.vue
Outdated
<v-checkbox v-model="widget.options.limitSamples" label="Limit number of samples" color="primary" /> | ||
<v-text-field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
This is a plot widget that can be configured to consume from any data-lake variable of type `number`.
d4cab1c
to
292d5db
Compare
Was coming here to say that 😆 |
Allows the user to plot any data-lake variable.
Kapture.2024-11-30.at.06.42.16.mp4
Relevant to #85.