Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: beacon incorrectly changes ethernet domain names when choosing a custom mDNS Hostname #2548

Open
1 task done
ES-Alexander opened this issue Apr 17, 2024 · 0 comments · May be fixed by #2549
Open
1 task done
Labels
bug Something isn't working core Issue related to BlueOS-core P1 - Important Priority High priority task

Comments

@ES-Alexander
Copy link
Collaborator

ES-Alexander commented Apr 17, 2024

Bug description

By default the ethernet interface is accessible via blueos.local, blueos-ethernet.local, and companion.local.

After configuring a custom mDNS hostname the defaults get ignored and overwritten, after which it's only possible to access the ethernet interface via blueos.local and <custom>.local, which I believe (for consistency with the defaults) should instead be blueos.local, <custom>-ethernet.local, companion.local, and possibly <custom>.local.

A pretty straightforward implementation would be to replace blueos with <custom> in each of the strings, and then if blueos is not in the list anymore append it.

Steps to reproduce

  1. Open a fresh install of BlueOS, or delete the beacon configs from the File Browser and restart the core container
  2. Access BlueOS via blueos-ethernet.local or companion.local
  3. Edit Vehicle Details in some way (even just changing the Vehicle Name still triggers the hostname overwrite)
  4. The page is no longer accessible, and the new hostname cannot be used with the -ethernet suffix

Primary pain point(s)

Intended behaviour doesn't work, and failing to connect to the interface is a critical issue, especially for users who don't know the default interface names that are always available (e.g. blueos-avahi.local).

Additional context

#1001 is another beacon configuration issue, although I don't believe they're related (but it might be worth trying to fix both at the same time).

Prerequisites

  • I have checked to make sure that a similar request has not already been filed or fixed.
@ES-Alexander ES-Alexander added bug Something isn't working core Issue related to BlueOS-core P1 - Important Priority High priority task labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Issue related to BlueOS-core P1 - Important Priority High priority task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant