Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a possibility to pass metainfo by Hooks for SRT stream #2653

Closed
bcherniakh opened this issue Nov 6, 2023 · 2 comments
Closed

Provide a possibility to pass metainfo by Hooks for SRT stream #2653

bcherniakh opened this issue Nov 6, 2023 · 2 comments

Comments

@bcherniakh
Copy link
Contributor

bcherniakh commented Nov 6, 2023

Describe the feature

Problem

Since v1.2.1 it is possible to use the MTX_QUERY env variable with hooks like runOnReady, runOnNotReady, etc. It is extremely convenient as this gives the possibility to add some token to query and recognize the stream originator in the API invoked by the hook or pass additional meta in that invocation. But this does not work for the SRT type of stream. The MTX_QUERY is empty for SRT. I believe that this might be so because of security reasons as the query for the SRT might contain login and password.

In my use case, I need to identify the user that initiated the stream in the hook and it would be really helpful if there was a possibility to pass either the query as an MTX_QUERY env var or SRT login.

** Possible solutions **

  1. Add the new optional part for srtNewConnReq that can have the semantics of query and be used as query of pathAccessRequest
  2. Pass the entire srtNewConnReq as the query to pathAccessRequest and env
  3. Add the new env var that reflects credentials where applicable

I would gladly provide a PR for the acceptable solution

Thank you!

Copy link
Contributor

github-actions bot commented Nov 6, 2023

This issue is being automatically closed because it does not follow the issue template.
Please reopen the issue and make sure to include all sections of the template.

@github-actions github-actions bot closed this as completed Nov 6, 2023
Copy link
Contributor

This issue is being locked automatically because it has been closed for more than 6 months.
Please open a new issue in case you encounter a similar problem.

@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant