Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git patch with empty emails causing parse errors #41

Closed
ajinabraham opened this issue Mar 6, 2024 · 1 comment · Fixed by #42
Closed

git patch with empty emails causing parse errors #41

ajinabraham opened this issue Mar 6, 2024 · 1 comment · Fixed by #42

Comments

@ajinabraham
Copy link

ajinabraham commented Mar 6, 2024

I have a git patch that is triggering this line

return PatchIdentity{}, fmt.Errorf("invalid identity string: %s", s)

commit 44b179bf547c84cb588480558de71df1e9243aaf
Author: bot-deploy Github Action <>
Date:   Tue Mar 5 17:07:58 2024 +0000

    Export updated bot artifact

diff --git a/bot_exports/ba3e9571-b1d9-45cb-be06-a7b4a2e279e7.blob b/bot_exports/ba3e9571-b1d9-45cb-be06-a7b4a2e279e7.blob
index 4ea75f9..f92448c 100644
Binary files a/bot_exports/ba3e9571-b1d9-45cb-be06-a7b4a2e279e7.blob and b/bot_exports/ba3e9571-b1d9-45cb-be06-a7b4a2e279e7.blob differ

Author: bot-deploy Github Action <> is causing parsing to fail. Can this be gracefully handled, like returning an empty email?

@bluekeyes
Copy link
Owner

Thanks for reporting this. I ran an experiment with git and it seems like it does accept patches with empty emails, so I've updated ParsePatchIdentity to accept the same things. That change is available in version 0.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants