Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Prague): Add EIP-7702 #1565

Merged
merged 14 commits into from
Jun 28, 2024
Merged

feat(Prague): Add EIP-7702 #1565

merged 14 commits into from
Jun 28, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Jun 24, 2024

Waiting for alloy-rs/alloy#950

crates/primitives/src/env.rs Show resolved Hide resolved
if self.tx.authorization_list.is_some() {
// Check if other fields are unset.
if self.tx.max_fee_per_blob_gas.is_some() || !self.tx.blob_hashes.is_empty() {
return Err(InvalidTransaction::AuthorizationListInvalidFields);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this not be BlobVersionedHashesNotSupported? or something similar, this error is a bit vague since the error is that we have an auth list and blobs

Copy link
Member Author

@rakita rakita Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, EnvTx sucks rn, as we have all fields in one struck. This error marks AuthorizationList TX which has set some fields by mistake.

Copy link
Contributor

github-actions bot commented Jun 24, 2024

Valgrind Results:

==3923== Cachegrind, a cache and branch-prediction profiler
==3923== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3923== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3923== Command: target/release/snailtracer
==3923== 
--3923-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.829990925s
==3923== 
==3923== I   refs:      427,039,778
==3923== I1  misses:          4,350
==3923== LLi misses:          2,802
==3923== I1  miss rate:        0.00%
==3923== LLi miss rate:        0.00%
==3923== 
==3923== D   refs:      204,076,924  (132,268,766 rd   + 71,808,158 wr)
==3923== D1  misses:        344,823  (    204,875 rd   +    139,948 wr)
==3923== LLd misses:        137,805  (      4,488 rd   +    133,317 wr)
==3923== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3923== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3923== 
==3923== LL refs:           349,173  (    209,225 rd   +    139,948 wr)
==3923== LL misses:         140,607  (      7,290 rd   +    133,317 wr)
==3923== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita requested a review from onbjerg June 24, 2024 19:26
@rakita
Copy link
Member Author

rakita commented Jun 24, 2024

@onbjerg this should be okay to go. Need alloy-rs/alloy#964 and a new version of alloy-eips to be published. Have patches and disabled alloy as it has dependencies.

Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 64dc252 into main Jun 28, 2024
26 checks passed
This was referenced Jun 28, 2024
@rakita rakita deleted the rakita/eip7702 branch June 30, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants