Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(interpreter): unbox contract field #1228

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

DaniPopes
Copy link
Collaborator

I don't see a reason for this to be boxed, it's 184 bytes big when the interpreter is 256 already, bringing it to 432 doesn't change much.

This doesn't affect the size of frames as they themselves are boxed.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was useful when we had recursive loop calls. But now it can be removed

@rakita rakita merged commit 52c8f92 into bluealloy:main Mar 26, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Mar 26, 2024
@DaniPopes DaniPopes deleted the unbox-interpreter-contract branch March 26, 2024 23:08
fubuloubu pushed a commit to ApeWorX/revm that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants