fix: use docker to build images (#16) #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes were made in the `testing` branch however the main branch hasn't been updated with docker builds. This PR includes the changes to build with docker and use a cache into the `main` version of the action
gmpinder
previously approved these changes
Mar 9, 2024
xynydev
reviewed
Mar 9, 2024
xynydev
reviewed
Mar 9, 2024
xynydev
reviewed
Mar 9, 2024
|
Need to test this first. Also wondering, should I include the testing in this PR or should I add it in a seperate PR? |
gmpinder
reviewed
Mar 9, 2024
gmpinder
requested changes
Mar 10, 2024
xynydev
changed the title
testing branch
xynydev
changed the title
Co-authored-by: Gerald Pinder <[email protected]>
Co-authored-by: Gerald Pinder <[email protected]>
Co-authored-by: Gerald Pinder <[email protected]>
Co-authored-by: Gerald Pinder <[email protected]>
Co-authored-by: Gerald Pinder <[email protected]>
gmpinder
reviewed
Mar 10, 2024
gmpinder
approved these changes
Mar 11, 2024
xynydev
reviewed
Mar 12, 2024
xynydev
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes were made in the
testingbranch however the main branch hasn't been updated with docker builds. This PR includes the changes to build with docker and use a cache into themainversion of the action