Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete modules #7

Open
6 of 9 tasks
jcfr opened this issue Jun 28, 2019 · 1 comment
Open
6 of 9 tasks

Remove obsolete modules #7

jcfr opened this issue Jun 28, 2019 · 1 comment

Comments

@jcfr
Copy link
Collaborator

jcfr commented Jun 28, 2019

@blowekamp

  • Which module(s) do you suggest we remove ?
  • Should we rename the extension or even create a new one with only the relevant module ?
  • Should we port the existing legacy Editor effect to the new Segmentations module ? @lassoan is there anything we should consider adding to the SlicerSegmentEditorExtraEffects extension ?
  • Should we remove LabelObjectStatistics and/or improve SegmentStatistics available in Slicer ?

CLI modules

  • BinShrink: CLI module to reduce the size of an image by an integer factor in each dimension and averages by the same size
  • IASEMImport: CLI module to import a large volume and reduce is size by streaming.
  • IASEMImportSeries: CLI module to import a directory of tiffs from IASEM, applying a slice-to-slice transfrom, multi-resolution, and region of interest extraction.
  • NucleusClosing: CLI module that produces a outter contour and inner contour for nucleus closing
  • SpacingAwareCurvatureDiffusion: CLI module top performs anisotropic diffusion on an image using a modified curvature diffusion equation (MCDE). More details here

Legacy Editor effects

  • BinaryWatershed: Legacy Editor effect to split selected label into separate objects based at minimum size the objects.
  • DoubleThresholdEffect: Legacy Editor effect
  • WatershedFromMarker: Legacy Editor effect to apply the watersheds from markers segmentation from multiple initial labels.

Scripted modules

  • LabelObjectStatistics: Scripted module with implementation copied from legacy Label Statistic module.
@blowekamp
Copy link
Owner

To Keep:

  • IASEMImport: This is a fairly general large image import CLI, which uses ITK IO streaming to read an ROI from a file and intelligently perform "shrinking" by skilling whole z slices not needed.
  • NucleusClosing: This was a very specific task for refining segmentations, however this CLI uniquely used SimpleITK in C++, so keeping it around as an example would be a good thing, unless there is a better place for this type of example.
  • LabelObjectStatistics: This uses ITK statistics filters which I have worked on. If I recall correctly, there were some performance issues with the internal Slicer statistics modules, and the ITK shape label statics had additional import statistics needed for the IASEM problem.

To Remove

  • BinShrink: This filter is not easily available in the SimpleFilters module.
  • IASEMImportSeries: This is very specific to the IASEM work flow the lab was using, not generally reusable.
  • SpacingAwareCurvatureDiffusion: "This a modified derivation of the Curvature Anisotropic Diffusion module which scaled the time step by the minimum spacing, so that the this filter will automatically choose an optimal time step by default." - This CLI just fixed the default time-step for images with very small space. It's a small change that is not worth the maintain ace effort to keep around
  • Legacy Editor Effects: I believe the WatershedFromMarker did get moved into the old editor, but looks like it was not moved to the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants