You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In-place sorting means that the initially passed in array will be modified, and does not need to be re-assigned.
If the merge_sort_in_place() function creates a new array and returns it without modifying the original, this test should fail. Currently, it does not.
Fix
Call the merge_sort_in_place() function before testing, and then assertEqual() the array itself to the expected value. This should test whether the array was truly modified in place.
Code Reference
https://github.com/LambdaSchool/cs-module-project-recursive-sorting/blob/0fd49e2dbd425875300446e6bc444d6350cf3ae9/src/recursive_sorting/test_recursive.py#L21-L34
Bug
In-place sorting means that the initially passed in array will be modified, and does not need to be re-assigned.
If the
merge_sort_in_place()
function creates a new array and returns it without modifying the original, this test should fail. Currently, it does not.Fix
Call the
merge_sort_in_place()
function before testing, and thenassertEqual()
the array itself to the expected value. This should test whether the array was truly modified in place.Fixed in PR #11.
The text was updated successfully, but these errors were encountered: