Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature | Multi Sim Uses new tracer #72

Merged
merged 6 commits into from
Sep 26, 2022
Merged

Feature | Multi Sim Uses new tracer #72

merged 6 commits into from
Sep 26, 2022

Conversation

alexcampbelling
Copy link

No description provided.

dmarzzz
dmarzzz suggested changes Sep 19, 2022
View reviewed changes
Copy link

@dmarzzz dmarzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requests , nothing big. Also I understand the approach has duplicate code due to some tech debt so no worries there

core/state_processor.go Outdated Show resolved Hide resolved
core/state_processor.go Outdated Show resolved Hide resolved
internal/ethapi/api.go Outdated Show resolved Hide resolved
@dmarzzz dmarzzz self-requested a review September 21, 2022 14:09
@alexcampbelling alexcampbelling merged commit 4e36a82 into mempool-feed-stage Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmarzzz dmarzzz dmarzzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcampbelling @dmarzzz