From e8e1a2696012a1118921ce630cd4669413e6c503 Mon Sep 17 00:00:00 2001 From: Eli Hart Date: Mon, 30 Oct 2023 21:02:44 -0700 Subject: [PATCH] Update changelog, fix "unsupported" tests, add param comment --- CHANGELOG.md | 15 +++++++++++++++ compose-unsupported-tests/build.gradle.kts | 4 ++-- .../radiography/internal/ComposeLayoutInfo.kt | 4 ++++ 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5faa4f7..f01375d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,21 @@ Change Log ========== +Version 3.0.0 +------------- + +_2023-10-30_ + +Compose 1.5 is now supported. Due to breaking API changes within the Compose runtime, this version +is not compatible with earlier versions of Compose. If you need to use an earlier version of Compose, +use a 2.x version of Radiography. + +The ScannableView.ComposeView has a new property, `semanticsConfigurations`, which exposes SemanticsConfiguration objects +from both Modifiers and the new Semantics tree. In newer versions of Compose, SemanticsConfigurations cannot +be read from the Modifier list, and are present only in the Semantics tree, +so if you were previously using the `modifiers` property for this you should switch to +using `semanticsConfigurations` instead. + Version 2.4.1 ------------- diff --git a/compose-unsupported-tests/build.gradle.kts b/compose-unsupported-tests/build.gradle.kts index 4134648..b1fa86b 100644 --- a/compose-unsupported-tests/build.gradle.kts +++ b/compose-unsupported-tests/build.gradle.kts @@ -9,7 +9,7 @@ plugins { * Allows using a different version of Compose to validate that we degrade gracefully on apps * built with unsupported Compose versions. */ -val oldComposeVersion = "1.0.1" +val oldComposeVersion = "1.3.0" android { compileSdk = 34 @@ -31,7 +31,7 @@ android { } composeOptions { - kotlinCompilerExtensionVersion = oldComposeVersion + kotlinCompilerExtensionVersion = Versions.Compose } packaging { diff --git a/radiography/src/main/java/radiography/internal/ComposeLayoutInfo.kt b/radiography/src/main/java/radiography/internal/ComposeLayoutInfo.kt index 436b089..94813d0 100644 --- a/radiography/src/main/java/radiography/internal/ComposeLayoutInfo.kt +++ b/radiography/src/main/java/radiography/internal/ComposeLayoutInfo.kt @@ -65,6 +65,10 @@ internal sealed class ComposeLayoutInfo { */ internal fun Group.computeLayoutInfos( parentName: String = "", + /** + * The semantics owner for this Group. This is used to look up the semantics nodes for each + * layout node. + */ semanticsOwner: SemanticsOwner? = null, ): Sequence { val name = parentName.ifBlank { this.name }.orEmpty()