New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass `timeline` client into cron at start rather than grabbing it from context #3704

Closed

wesbillman opened this issue Dec 10, 2024 · 0 comments · Fixed by #3722

Assignees

Labels

techdebt

Collaborator

wesbillman commented Dec 10, 2024

Then we can get rid of grabbing it from context here: https://github.com/TBD54566975/ftl/blob/main/backend/cron/service.go#L135

There might be other services that need a similar change.

wesbillman added the techdebt label

wesbillman self-assigned this

ftl-robot mentioned this issue

Open

wesbillman mentioned this issue

fix: inject timeline client instead of using ctx #3722

Merged

wesbillman closed this as completed in #3722

wesbillman closed this as completed in

73eed73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment