Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema validate has many places that fill in ref.Module if blank #3526

Open
matt2e opened this issue Nov 26, 2024 · 1 comment
Open

Schema validate has many places that fill in ref.Module if blank #3526

matt2e opened this issue Nov 26, 2024 · 1 comment
Assignees
@matt2e

Comments

@matt2e
Copy link
Collaborator

matt2e commented Nov 26, 2024

Seems that we walk the tree but validate nodes before we get to the ref and fill it in with the centralized logic. So each specidic validation func has to check the ref's module and fill it in before calling Resolve.
@github-actions github-actions bot added the triage Issue needs triaging label Nov 26, 2024
@ftl-robot ftl-robot mentioned this issue Nov 26, 2024
Open
@alecthomas
Copy link
Collaborator

What's an example of this?

@bradleydwyer bradleydwyer changed the title Schema validate has many places that fill in ref.Name if blank Schema validate has many places that fill in ref.Module if blank Dec 2, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Dec 2, 2024
@matt2e matt2e mentioned this issue Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle refs without module block/ftl
2 participants
@alecthomas @matt2e