Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change build engine to extract source control positions #3384

Open
alecthomas opened this issue Nov 14, 2024 · 1 comment
Open

Change build engine to extract source control positions #3384

alecthomas opened this issue Nov 14, 2024 · 1 comment
Labels
next Work that will be be picked up next

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Nov 14, 2024 •
edited
Loading

Instead of local files, extract canonical source control links. Probably use the git head ref to permalink, and look for common source control repos, eg. [email protected]:TBD54566975/ftl.git -> https://github.com/TBD54566975/ftl on 666085c would be https://github.com/TBD54566975/ftl/tree/666085cb8bf11e74e5af25b63876d14ebc5c8668
@github-actions github-actions bot added the triage Issue needs triaging label Nov 14, 2024
@ftl-robot ftl-robot mentioned this issue Nov 14, 2024
Open
@stuartwdouglas
Copy link
Collaborator

IMHO we should keep the existing behaviour for FTL dev, this should just be for release builds.

@bradleydwyer bradleydwyer added next Work that will be be picked up next and removed triage Issue needs triaging labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next Work that will be be picked up next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alecthomas @bradleydwyer @stuartwdouglas