Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate the two purposes of VerbService into two separate gRPC service definitions #1405

Closed
alecthomas opened this issue May 4, 2024 · 1 comment
Closed

Separate the two purposes of VerbService into two separate gRPC service definitions #1405

alecthomas opened this issue May 4, 2024 · 1 comment
Labels
intermediate A task requiring an intermediate level of knowledge

Comments

@alecthomas
Copy link
Collaborator

One of its purposes is to allow calls into a user module, the other is to allow user modules to obtain and use resources on the controller. The interface currently conflates the two, but they should be separated.
@alecthomas alecthomas added the good first issue Good for newcomers label May 4, 2024
@github-actions github-actions bot added the triage Issue needs triaging label May 4, 2024
@alecthomas alecthomas mentioned this issue May 4, 2024
Open
@alecthomas alecthomas removed the triage Issue needs triaging label May 6, 2024
@alecthomas alecthomas added intermediate A task requiring an intermediate level of knowledge and removed good first issue Good for newcomers labels May 17, 2024
@stuartwdouglas
Copy link
Collaborator

I think this is done with the recent changes to split this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
intermediate A task requiring an intermediate level of knowledge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alecthomas @stuartwdouglas