Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need a way to run [startup] command from ftl-project tomls when running tests #1343

Closed
mistermoe opened this issue Apr 26, 2024 · 0 comments · Fixed by #1825
Closed

We need a way to run [startup] command from ftl-project tomls when running tests #1343

mistermoe opened this issue Apr 26, 2024 · 0 comments · Fixed by #1825
Assignees
@safeer

Comments

@mistermoe
Copy link
Collaborator

mistermoe commented Apr 26, 2024 •
edited by wesbillman
Loading

Pairing with @wesbillman. This came up. adding an issue here so we don't forget

This might be implemented short-term via ftl serve (which currently doesn't run the startup command)
Or longer-term perhaps we introduce a ftl test command that can be use when running tests.

cc: @matt2e this might be related to the testing journey you're about to embark on.
@github-actions github-actions bot added the triage Issue needs triaging label Apr 26, 2024
@alecthomas alecthomas mentioned this issue Apr 26, 2024
Open
@wesbillman wesbillman added the next Work that will be be picked up next label Apr 29, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Apr 29, 2024
@wesbillman wesbillman changed the title [Discuss] project toml startup command should run as part of ftl serve instead of just ftl dev We need a way to run [startup] command from ftl-project tomls when running tests Apr 29, 2024
@safeer safeer mentioned this issue Jun 18, 2024
Merged
@safeer safeer self-assigned this Jun 18, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Jun 18, 2024
@safeer safeer closed this as completed in 923e2b3 Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@safeer safeer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: move startup command exec from Dev to cmd_serve block/ftl
3 participants
@wesbillman @safeer @mistermoe