From 0e69f9d91fd2c4d69dc5a4392de2f1bd36e6e7ff Mon Sep 17 00:00:00 2001 From: Blake Blackshear Date: Sun, 13 Nov 2022 10:05:53 -0600 Subject: [PATCH] couple docs updates --- docs/docs/contributing.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/docs/contributing.md b/docs/docs/contributing.md index 0d5c49262d..8229b8abe2 100644 --- a/docs/docs/contributing.md +++ b/docs/docs/contributing.md @@ -126,7 +126,7 @@ ffmpeg -c:v h264_qsv -re -stream_loop -1 -i https://streams.videolan.org/ffmpeg/ - [Frigate source code](#frigate-core-web-and-docs) - All [core](#core) prerequisites _or_ another running Frigate instance locally available -- Node.js 14 +- Node.js 16 ### Making changes @@ -169,6 +169,7 @@ npm run lint ``` - Add to unit tests and ensure they pass. As much as possible, you should strive to _increase_ test coverage whenever making changes. This will help ensure features do not accidentally become broken in the future. +- If you run into error messages like "TypeError: Cannot read properties of undefined (reading 'context')" when running tests, this may be due to these issues (https://github.com/vitest-dev/vitest/issues/1910, https://github.com/vitest-dev/vitest/issues/1652) in vitest, but I haven't been able to resolve them. ```console npm run test @@ -181,7 +182,7 @@ npm run test ### Prerequisites - [Frigate source code](#frigate-core-web-and-docs) -- Node.js 14 +- Node.js 16 ### Making changes