-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot run Optimize command with Laravel 11 #47
Comments
Managed to reproduce it. Super odd. I don't have time atm to deep dive into this so would appreciate it if anyone has any insights. |
I just realised that Laravel 11's |
In the $compiler = $this->laravel['view']->getEngineResolver()->resolve('blade')->getCompiler(); Dumping this instance, it doesn't have all the Heroicon aliases registered:
If I swap that out and get the dd(app('blade.compiler'));
Perhaps this is a bug with the |
Is this issue when only using heroicons or all icon packages part of blade-ui-kit? |
I didn't test with blade-ui-kit as I was using herocions specifically. Easy fix for the meantime is to simply call |
Ya, that is what I ended up doing for all my deployment scripts after upgrading to Laravel 11. I hope this gets fixed soon. |
Any news on this issue? i have the same problem with |
Sorry all, I really want to see this one fixed but just don't have the time right now (I have a kid underway). I'd love for anyone to be able to help out here. |
Best of luck and congratulations, @driesvints! I faced the same issue, and will try to debug today. |
This seems to be fixed in laravel/framework v11.8.0. Not exactly sure where it was fixed, probably related PR in the framework: |
Would be cool if more people could confirm this! @Jubeki is laravel/framework#50619 fixed then as well? |
Should be, as it describes the same issue. |
Yeah - this is back in action for me after updating. Nice catch @Jubeki |
I get the same error. In my development environment on the Mac (macos 15) the command runs without error.
When I upload the project to our web server, I get an error:
Here is the stack trace:
|
Description:
I upgraded an existing app to Laravel 11, tests ran fine, but it failed during deployment running
php artisan optimize
. The page works fine when viewed in a browser (the icon appears). I tried to determine if it was something specific to my project but I was able to replicate this in a brand new Laravel 11 project also.Steps To Reproduce:
Create a new Laravel 11 project, add this library.
laravel new heroicons cd heroicons composer require blade-ui-kit/blade-heroicons
Add an icon to the welcome page:
<x-heroicon-s-bars-3 />
The text was updated successfully, but these errors were encountered: