Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make submission of 0 values configurable #14

Open
dirkraft opened this issue Oct 22, 2015 · 0 comments
Open

make submission of 0 values configurable #14

dirkraft opened this issue Oct 22, 2015 · 0 comments

Comments

@dirkraft
Copy link
Contributor

This logic should be configurable: https://github.com/blacklocus/metrics-cloudwatch/blob/master/src/main/java/com/blacklocus/metrics/CloudWatchReporter.java#L268-L272

Currently 0 values for counter-based metrics are omitted to save on API requests.

This should be configurable because 0 values may be significant in certain contexts.

Example
10 machines submit a counter at intervals of 1 minute. The counter is of the number of work items processed in the last minute. Over the last minute, machines 1-9 accomplished 1 work unit and each submitted a metric with value 1, and machine 10 accomplished 0 work units and submitted no metric at all.

Currently: CloudWatch over last minute

  • sum: 9
  • samples: 9
  • average: 1
  • min: 1
  • max: 1

Most developers would probably want a more representative aggregation:

  • sum: 9
  • samples: 10
  • average: 0.9
  • min: 0
  • max: 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant