Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Dropdown runs outside of container on mobile #505

Closed
blackbaud-brandonhare opened this issue Mar 21, 2017 · 3 comments
Closed

Dropdown runs outside of container on mobile #505

blackbaud-brandonhare opened this issue Mar 21, 2017 · 3 comments

Comments

@blackbaud-brandonhare
Copy link
Contributor

blackbaud-brandonhare commented Mar 21, 2017

Expected behavior

The text should adjust to the size of the container.

Actual behavior

The text overflows outside of the container.

Steps to reproduce

  1. Open the SKYUX2 documentation for the Action Button in Chrome.
  2. Use the device toolbar to view the page on an iPhone 5 (or at 320px width).
  3. Scroll down to Code sample section

image

@Blackbaud-PatrickOFriel
Copy link
Contributor

So this is specifically a problem with tab dropdowns, not dropdowns in general, because the parent tabset control has overflow: hidden applied to it. We have a couple possibilities.

  1. Cut off the tab dropdown button title when it's longer than the screensize, and add text-overflow: ellipsis.

(For my use if we choose this sky-tabset-dropdown: width: 100%, sky-dropdown-button-type-tab: width: 100%, display flex on parent of title and arrow, flex-shrink: 1 overflow: hidden text-overflow: ellipsis on title parent, flex-grow: 1 on arrow parent)

  1. Add some sort of word wrap to the title which will cause wrapping when the title is longer than the screensize.

What do you think, @Blackbaud-ToddRoberts, ?

@Blackbaud-ToddRoberts
Copy link
Contributor

Blackbaud-ToddRoberts commented Apr 10, 2017

Ellipsis seems safer in case someone uses a narrow button, where wrapping would make it take up a whole vertical page.

@Blackbaud-PatrickOFriel
Copy link
Contributor

In 2.0.0-beta.18

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants