Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinned tab favicon showing #58

Closed
LordRishav opened this issue Jun 4, 2021 · 1 comment
Closed

Pinned tab favicon showing #58

LordRishav opened this issue Jun 4, 2021 · 1 comment
Labels
Class::Icon Icon for panels, menus, libraries Component::Tabbar Tab or tabbar Issue::Duplicate This issue or pull request already exists

Comments

@LordRishav
Copy link

Is your feature request related to a problem? Please describe.

The close button for a pinned tab is shown instead of the favicon

Describe the solution you'd like

The close button should be replaced by the favicon for the website for aesthetic reasons. Just like in Photon:

https://i.imgur.com/vLcN3rW.png

The current pinned tab situation in Lepton:

https://i.imgur.com/e6JAFJ3.png

Describe alternatives you've considered
N/A

Additional context
This issue is a feature request, and the fix is merely for aesthetic reasons
@black7375 black7375 added Class::Layout-Others Layout issues except Padding and Size issues Component::Tabbar Tab or tabbar Class::Icon Icon for panels, menus, libraries Issue::Duplicate This issue or pull request already exists and removed Class::Layout-Others Layout issues except Padding and Size issues labels Jun 4, 2021
@black7375
Copy link
Owner

Currently, I am focusing on bug fixes rather than major feature changes for release #31.
There have been several similar requests, and I understand.

It will definitely be reflected in the next release.
But it is not reflected now.

Temporary solution.
https://github.com/black7375/Firefox-UI-Fix/compare/hide-closebutton-at-pinned

Duplicate #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Class::Icon Icon for panels, menus, libraries Component::Tabbar Tab or tabbar Issue::Duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@black7375 @LordRishav