Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text overlap when auto hiding navbar #517

Closed
Zabooby opened this issue Nov 27, 2022 · 11 comments
Closed

Text overlap when auto hiding navbar #517

Zabooby opened this issue Nov 27, 2022 · 11 comments
Labels
Class::Color Color, background, blur, etc. Component::URLbar URL(address), search field or view Difficult::Unknown Unknown cause or difficult to reproduce Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working

Comments

@Zabooby
Copy link

Zabooby commented Nov 27, 2022

The text of bookmarks overlaps the url bar text.

image

@Zabooby Zabooby added the Issue::Bug Something isn't working label Nov 27, 2022
@black7375 black7375 added Env::Windows Issues on Windows10, Windows11, unknown windows Class::Color Color, background, blur, etc. Component::URLbar URL(address), search field or view labels Nov 30, 2022
@black7375
Copy link
Owner

Please write down your environment and settings.
Without it, the reproduction is very hard.

@Zabooby
Copy link
Author

Zabooby commented Nov 30, 2022

Windows 11
Firefox version: 107.0.1
userChrome.autohide.navbar to true

@black7375 black7375 added Difficult::Hard Issues that are difficult to solve or impossible Difficult::Unknown Unknown cause or difficult to reproduce and removed Difficult::Hard Issues that are difficult to solve or impossible labels Dec 5, 2022
@black7375
Copy link
Owner

Hmm..There seems to be more conditions.
In my environment, urlbar background does not seem transparent.

image

@Zabooby
Copy link
Author

Zabooby commented Dec 5, 2022

Maybe it's because my url background colour and bookmarks bar colour are the same?

Also it only overlaps with icons/text on the bookmarks bar

image

@black7375
Copy link
Owner

As far as I know, it was fixed in v6.4.0.

See #501 (aff13a5), 1cbcb9a

@Zabooby
Copy link
Author

Zabooby commented Dec 6, 2022

I've made my own solution, put everything in folders so there is no overlap. Should I close the issue?
image

@black7375
Copy link
Owner

Once it can't reproduced, I will close it if it has been solved.
If you have the same problem in the latest version later, please contact me again. 👍

@Zabooby
Copy link
Author

Zabooby commented Dec 6, 2022

I'm already on the latest version. Also is it possible to change the colour of the separator in the search bar in the picture above?
image

@black7375
Copy link
Owner

It's strange..

If you solve it, please share the relevant code here.
It helps other users who patch or search.


Here is a urlView separator color

.urlbarView-title-separator::before {
  color: red;
}

@Zabooby
Copy link
Author

Zabooby commented Dec 6, 2022

I'll try and set up a fresh profile myself tomorrow and see if can reproduce it, I might have forgot some changes I made. I'll keep you posted.

I tried the code but the colour isn't changing.

@Zabooby
Copy link
Author

Zabooby commented Dec 7, 2022

It's strange..

If you solve it, please share the relevant code here. It helps other users who patch or search.

Here is a urlView separator color

.urlbarView-title-separator::before {
  color: red;
}

I just made a fresh profile and installed v6.5.1 the bug is still there. These are all the changes that I had, see if you can replicate:

User.js

user_pref("userChrome.icon.disabled",                       true);
user_pref("userChrome.tab.dynamic_separator",          false); // Original, Proton
user_pref("userChrome.autohide.navbar",                     true);
user_pref("userChrome.autohide.toolbar_overlap",            true);

userChrome.css

html#main-window menupopup:not(.in-menulist) {
  --menu-border-color: black !important;
  --panel-border-color: var(--menu-border-color) !important;
}
html#main-window menupopup:not(.in-menulist) menuseparator {
 --menu-border-color: black !important;
 border-top: 1px solid var(--menu-border-color) !important;
}
#customization-container {
	background-color: #1E2021 !important;
	background-image: none !important;
}

#customization-footer {
	border: black !important;
	background-color: #1E2021 !important;
}
:root {
  --panel-separator-color: black !important;
}

html#main-window menupopup:not(.in-menulist, [placespopup]) menuseparator,
toolbarbutton menupopup[placespopup] menuseparator::before {
  --menu-border-color: black !important;
}
.urlbarView-title-separator::before {
  color: black;
}

Also the separator that I was talking about above was this one, is it possible to change the colour?:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class::Color Color, background, blur, etc. Component::URLbar URL(address), search field or view Difficult::Unknown Unknown cause or difficult to reproduce Env::Windows Issues on Windows10, Windows11, unknown windows Issue::Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants