Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port install script to Powershell #119

Closed
jupjohn opened this issue Jul 11, 2021 · 11 comments
Closed

Port install script to Powershell #119

jupjohn opened this issue Jul 11, 2021 · 11 comments
Labels
Env::Windows Issues on Windows10, Windows11, unknown windows Install Problems in the installation process Issue::Enhancement New feature or request

Comments

@jupjohn
Copy link
Contributor

jupjohn commented Jul 11, 2021

Is your feature request related to a problem? Please describe.
The current install script is written in bash - preventing it from being run on most Windows-based machines without the use of git-bash/WSL.

Describe the solution you'd like
The install script should be ported to Powershell (as part of v3) for Windows installations.

Describe alternatives you've considered
-none

Additional context
Wanted an issue for tracking against the v3 "powershell script" milestone. Happy to take a dig at implementing it.

@black7375 black7375 added Install Problems in the installation process Env::Windows Issues on Windows10, Windows11, unknown windows labels Jul 11, 2021
@ghost
Copy link

ghost commented Jul 12, 2021

#109
Won't be easy since powershell isn't as powerfull as bash.

@black7375 black7375 mentioned this issue Jul 12, 2021
25 tasks
@ojaha065
Copy link

powershell isn't as powerfull as bash

This is very much not true. While personally I'm not a huge fan of PowerShell, everything that can be done using Bash, can also be done just as easily in PowerShell.

@ghost
Copy link

ghost commented Jul 12, 2021

Ok..Maybe I should try to study it deeper.

@jupjohn
Copy link
Contributor Author

jupjohn commented Jul 12, 2021

Won't be easy since powershell isn't as powerfull as bash.

You'll find that PS has a lot more power with .NET behind it. Everything done in the current bash install script can be done in PS just fine. I'll create a draft PR with the prototype if you'd like to see how it works.

@ghost
Copy link

ghost commented Jul 12, 2021

Oh maybe that's the reason I felt powershell wasn't powerful enough. But do you need the .NET framework runtime to run .NET commands in powershell?

@theseer
Copy link

theseer commented Jul 12, 2021

While I have to admit my days of writing extensions for Firefox date back to when chrome and XUL where still a thing: Why don't we create an actual extension to install things?

@black7375
Copy link
Owner

black7375 commented Jul 12, 2021

I've been using Bash for a long time, but I've rarely used PowerShell.
It will probably have to be made by trial and error. (Having a prototype would be of great help.)
I know that powershell, not cmd, has enough features, so it will be possible to implement.

There is one nice tool that was recently introduced.
I will move towards using ewen-lbh/ffcss, but it doesn't seem to support the upgrade process yet.
So, for the time being, a script will be needed, but since it seems likely that functions such as upgrade/GUI/autoconfig(userChromeJS) will be included, I am thinking of switching at any time.

With one unified manager, I can spend more time fixing bugs or developing features.


tldr; I will release powershell script in this version, but I have to go in the direction of using ffcss.

@black7375 black7375 added the Issue::Enhancement New feature or request label Jul 12, 2021
@ojaha065
Copy link

@theseer

Why don't we create an actual extension to install things?

It's just not possible anymore. WebExtensions API is very limited (especially if compared to XUL) when it comes to editing the browser UI. See #47 .

@theseer
Copy link

theseer commented Jul 12, 2021

Sigh Thanks.

@jupjohn
Copy link
Contributor Author

jupjohn commented Jul 13, 2021

Created #122 for implementation.

@black7375
Copy link
Owner

Experimental powershell script is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Env::Windows Issues on Windows10, Windows11, unknown windows Install Problems in the installation process Issue::Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants