Fix CLI time measurement #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilmovva
force-pushed
the
timing-fix
branch
from
170510f to
fe0992e
Compare
andompesta
pushed a commit
to andompesta/flux
that referenced
this pull request
Nov 14, 2024
Co-authored-by: Neil Movva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Torch CUDA operations are async by default.
The original code stops the clock as soon as torch finishes issuing GPU operations, but the results wouldn't actually be ready at that point, so it's an underestimate. We need an explicit sync to correctly time end-to-end execution of the model.
Testing on flux-dev, 1024x768 resolution, 28-steps, on H100 SXM.
Before: 5520ms
After: 6040ms
Exact delta depends on how much the CPU is running ahead of the GPU, which varies significantly across systems. This also means that timings should be more stable after this change.
credit to @donglinz for finding this bug!