Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabixIndexedFile needs reference counting #73

Closed
charlesgregory opened this issue May 4, 2021 · 1 comment
Closed

TabixIndexedFile needs reference counting #73

charlesgregory opened this issue May 4, 2021 · 1 comment
Milestone
Version v0.13.0+h...

Comments

@charlesgregory
Copy link
Contributor

Similar to #69, but implementation is better. Moving forward the solution should always follow range rules, BUT make sure to renew the internal iterator in postblit to make sure the copied struct has a new iterator. Probably should also add reference counting.
@charlesgregory
Copy link
Contributor Author

Actually this is not true. It does conform to range rules. I am changing the title as we still need to add reference counting.

@charlesgregory charlesgregory changed the title TabixIndexedFile doesn't conform to Phobos range rules TabixIndexedFile needs reference counting May 11, 2021
@charlesgregory charlesgregory mentioned this issue Jun 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version v0.13.0+htslib-1.12
Development

No branches or pull requests
1 participant
@charlesgregory