Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version check warning #120

Open
charlesgregory opened this issue Oct 22, 2021 · 1 comment
Open

Version check warning #120

charlesgregory opened this issue Oct 22, 2021 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@charlesgregory
Copy link
Contributor

I would be nice if we could have some form of version checking. I built a program with dhtslib-1.13 against htslib-1.10.2 by mistake. Since ABI is still compatible between those htslib versions, program compiled and ran fine. Though it would be nice if we could emit a warning. Would this be possible or even wanted?

@charlesgregory charlesgregory added enhancement New feature or request question Further information is requested labels Oct 22, 2021
@jblachly
Copy link
Member

Well, as long as the so version is compatible (as you point out, 1.13 is compat with 1.10, but not 1.9), it should work -- I don't believe any data structures were changed within this ABI version -- and if you use a new symbol or function that was not defined in e.g. 1.10.2, it simply won't link.

That being said, a warning would be nice. don't work too hard on that RN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants