Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't load .env.local in rails' test environment #280

Merged
merged 11 commits into from
Jan 27, 2017

Commits on Jan 26, 2017

  1. don't load .env.local in rails' test environment

    In my opinion, the .env.local should not overwrite .env.test
    variables. When using .env.local for tests, the tests are not
    transparent and can't be executed for example on a CI server.
    
    As the documentation says, the `.env.local` is here for **local**
    overwrites. They should not overwrite a test specific variable. Tests
    should be run on every machine in every environment and shouldn't
    require any specification of environment variables. (My opinion)
    siegy22 committed Jan 26, 2017
    Configuration menu
    Copy the full SHA
    0869e05 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c9597d6 View commit details
    Browse the repository at this point in the history
  3. fix tests

    siegy22 committed Jan 26, 2017
    Configuration menu
    Copy the full SHA
    a1527f3 View commit details
    Browse the repository at this point in the history
  4. okay rubocop...

    siegy22 committed Jan 26, 2017
    Configuration menu
    Copy the full SHA
    d27f11d View commit details
    Browse the repository at this point in the history
  5. rebase, adjust tests

    siegy22 committed Jan 26, 2017
    Configuration menu
    Copy the full SHA
    0734ca1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b186a89 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5140a27 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2017

  1. Update changelog

    bkeepers committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    49fc29e View commit details
    Browse the repository at this point in the history
  2. Simplify dotenv_files

    bkeepers committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    6cc4d4f View commit details
    Browse the repository at this point in the history
  3. Consolidate rails specs

    bkeepers committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    40697ab View commit details
    Browse the repository at this point in the history
  4. Use inquirer method

    bkeepers committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    c1ebe6c View commit details
    Browse the repository at this point in the history