-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't load .env.local in rails' test environment #280
Merged
Merged
Commits on Jan 26, 2017
-
don't load .env.local in rails' test environment
In my opinion, the .env.local should not overwrite .env.test variables. When using .env.local for tests, the tests are not transparent and can't be executed for example on a CI server. As the documentation says, the `.env.local` is here for **local** overwrites. They should not overwrite a test specific variable. Tests should be run on every machine in every environment and shouldn't require any specification of environment variables. (My opinion)
Configuration menu - View commit details
-
Copy full SHA for 0869e05 - Browse repository at this point
Copy the full SHA 0869e05View commit details -
Configuration menu - View commit details
-
Copy full SHA for c9597d6 - Browse repository at this point
Copy the full SHA c9597d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1527f3 - Browse repository at this point
Copy the full SHA a1527f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d27f11d - Browse repository at this point
Copy the full SHA d27f11dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0734ca1 - Browse repository at this point
Copy the full SHA 0734ca1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b186a89 - Browse repository at this point
Copy the full SHA b186a89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5140a27 - Browse repository at this point
Copy the full SHA 5140a27View commit details
Commits on Jan 27, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 49fc29e - Browse repository at this point
Copy the full SHA 49fc29eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cc4d4f - Browse repository at this point
Copy the full SHA 6cc4d4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40697ab - Browse repository at this point
Copy the full SHA 40697abView commit details -
Configuration menu - View commit details
-
Copy full SHA for c1ebe6c - Browse repository at this point
Copy the full SHA c1ebe6cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.