Skip to content

Commit

Permalink
fix: Leave function buttons and foot switches unmapped by default. Th…
Browse files Browse the repository at this point in the history
…is avoids closing the Mapping Assistant when pressing a function button or foot switch to select it for mapping in Cubase 13.
  • Loading branch information
bjoluc committed May 25, 2024
1 parent b7ca177 commit 9e17737
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 29 deletions.
25 changes: 0 additions & 25 deletions src/mapping/control.ts
Original file line number Diff line number Diff line change
Expand Up @@ -165,15 +165,6 @@ export function bindControlSection(
);
}

// Function buttons
for (const button of buttons.function) {
page.makeCommandBinding(
button.mSurfaceValue,
"MIDI Remote",
"Open MIDI Remote Mapping Assistant",
);
}

// Edit
page
.makeCommandBinding(buttons.edit.mSurfaceValue, "Edit", "Edit Channel Settings")
Expand Down Expand Up @@ -421,19 +412,3 @@ export function bindControlSection(
};
}
}

export function bindFootControl(
page: MR_FactoryMappingPage,
controlSectionElements: ControlSectionSurfaceElements,
) {
for (const footSwitch of [
controlSectionElements.footSwitch1,
controlSectionElements.footSwitch2,
]) {
page.makeCommandBinding(
footSwitch.mSurfaceValue,
"MIDI Remote",
"Open MIDI Remote Mapping Assistant",
);
}
}
6 changes: 2 additions & 4 deletions src/mapping/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { bindControlSection, bindFootControl, bindMouseValueControl } from "./control";
import { bindControlSection, bindMouseValueControl } from "./control";
import { bindEncoders } from "./encoders";
import { config } from "/config";
import { Device, MainDevice } from "/devices";
Expand Down Expand Up @@ -81,10 +81,8 @@ export function makeHostMapping(
.makeMixerBankChannel().mValue.mVolume,
);

// Display buttons, 1-8, F1-F8, Modify, Automation, Utility, Transport, Navigation, Jog wheel
// Display buttons, 1-8, Modify, Automation, Utility, Transport, Navigation, Jog wheel
bindControlSection(page, device, mixerBankZone, globalState);

bindFootControl(page, controlSectionElements);
}
}

Expand Down

0 comments on commit 9e17737

Please sign in to comment.